search

ng-matero / extensions

Angular Material Extensions Library.
https://ng-matero.github.io/extensions/
MIT License
393 stars 48 forks source link

wrong import of takeUntil and startWith operators from rxjs #208

Closed zeno-mioso closed 1 year ago

zeno-mioso commented 1 year ago

Hello,

I saw that these two operators are imported from rxjs in a wrong way (maybe? or am I wrong?).

I tried to fix if editing these two file :

node_modules/@ng-matero/extensions/fesm2020/mtxSelect.mjs node_modules/@ng-matero/extensions/fesm2015/mtxSelect.mjs

from this format :

import { Subject, merge, takeUntil, startWith } from 'rxjs';

to this format :

import { Subject, merge } from 'rxjs'; import { takeUntil, startWith } from 'rxjs/operators';

Is this something that make sense to you?

Thanks ( and thanks for you high valuable contribute to the community )

Zeno

nzbin commented 1 year ago

Please check the RxJS docs https://rxjs.dev/guide/importing If you use the latest version of v14 or v15, you should update the rxjs to 7.2 or above.