search

ng-matero / extensions

Angular Material Extensions Library.
https://ng-matero.github.io/extensions/
MIT License
393 stars 48 forks source link

Angular 13 support #73

Closed Plondrein closed 2 years ago

Plondrein commented 2 years ago

Now that Angular 13 is released, it would be cool to upgrade :)

wupaz commented 2 years ago

I'm stuck with this error SassError: Can't find stylesheet to import. ╷ 2 │ @use '~@angular/material/core/theming/theming'; │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

nzbin commented 2 years ago

I intend to upgrade Angular 13 in next month.

nzbin commented 2 years ago

I'm stuck with this error SassError: Can't find stylesheet to import. ╷ 2 │ @use '~@angular/material/core/theming/theming'; │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

Maybe it doesn't support Angular 13, I haven't try.

smorandi commented 2 years ago

no it does not, angular 13 let the tilde go. so for angular 13 it should just work without the ~ in front of the statement.

@use '@angular/material/core/theming/theming' should work…

however, if you are using intellij you got a problem then, since the current version og webstorm, intellij etc has a bug there, which should be fixed in the next release of their IDE

nzbin commented 2 years ago

@smorandi Ok, I will checkout and fix this issue.

smorandi commented 2 years ago

that‘ll be fantastic.

i think there will be two parts for angular 13. one which will involve more work since they get rid of the „view-engine“, while ngcc still is in place, they probably will remove it in a future version. so that would probably require more rework on the lib.

however, to make the scss angular 13 compatible, it really might just need that one change described earlier.

nzbin commented 2 years ago

I will upgrade Angular 13 this month, maybe this week.

nzbin commented 2 years ago

v13 has released.

davidecampello commented 2 years ago

Thanks for your amazing job!

Plondrein commented 2 years ago

Thanks!