search

ng-select / ng-select

:star: Native angular select component
https://ng-select.github.io/ng-select/
MIT License
3.29k stars 911 forks source link

ARIA listbox missing child roles #951

Closed iantrudell closed 5 years ago

iantrudell commented 5 years ago

Describe the bug Google Lighthouse Audits are at it again with Accessibility errors:

Elements with [role] that require specific children [role]s, are missing.

Some ARIA parent roles must contain specific child roles to perform their intended accessibility functions.

To Reproduce

  1. Add an ng-select with role="listbox"
  2. Run a Google Chrome Lighthouse Audit
  3. ng-select will fail Accessibility due to missing child roles from the listbox

Expected behavior Passed Accessibility tests

Screenshots accessibility-audit

Desktop (please complete the following information):

Additional context https://www.w3.org/TR/wai-aria-practices-1.1/#Listbox https://dequeuniversity.com/rules/axe/2.2/aria-required-children?application=lighthouse

stijnwesterhof commented 5 years ago

Having the same issue.. Got any fix?

varnastadeus commented 5 years ago

All roles are there, you get this error since dropdown doesn't exist in the DOM until control is not opened. I suggest to ignore this warning.

vivekshah-zymr commented 4 years ago

@iantrudell @stijnwesterhof @varnastadeus Any update on this? I am facing the same issue.

mwmcode commented 3 years ago

Error persists even with [isOpen]=true