Performance issue when showing / hiding auto-complete. - Githubissues

ng2-ui / auto-complete

Angular Auto Complete component and directive

https://ng2-ui.github.io/dist/#/auto-complete

MIT License

279 stars 123 forks source link

Performance issue when showing / hiding auto-complete. #237

Closed lemarsu closed 7 years ago

lemarsu commented 7 years ago

Steps to reproduce and a minimal demo

Make a page with multiples auto-complete fields.
Set an *ngIf on each auto-complete directive
Show/Hide all auto-completes multiple times by toggling the value set in *ngIf directive.
Enjoy performance degradation. Each click on the page can takes up to one second or more.

Current behavior

Each click on the page can takes up to one second or more. auto-complete directive listen for click event on document, but doesn't remove the listener on ngOnDestroy.

Expected/desired behavior

Each display of auto-complete should not impact performance of the rest of the application.