Fixed enter on empty field results in undefined

ng2-ui / auto-complete

Angular Auto Complete component and directive

https://ng2-ui.github.io/dist/#/auto-complete

MIT License

279 stars 123 forks source link

Fixed enter on empty field results in undefined #253

Closed ghost closed 7 years ago

ghost commented 7 years ago

https://github.com/ng2-ui/auto-complete/issues/252 and maybe related (?) https://github.com/ng2-ui/auto-complete/issues/236

Changed accept-user-input default to true.
Issues were reproduced by setting auto-select-first-item to false and accept-user-input to true and then pressing enter on the input when there are items available (without selecting them).

Thanks and feel free to make suggestions/comments about this PR :smile:

allenhwkim commented 7 years ago

it's getting complicated, IMO

Why don't we set accept-user-input default to true? It seems simpler to me and makes user to configure less.

ghost commented 7 years ago

Set accept-user-input to true when auto-select-first-item is set to false? Or just set the default to true?

allenhwkim commented 7 years ago

I think to set the default to true unless there is any issue

Sent from my iPhone

On Aug 12, 2017, at 7:40 PM, Edwin Vásquez notifications@github.com wrote:

Set accept-user-input to true when auto-select-first-item is set to false? Or just set the default to true?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub, or mute the thread.

ghost commented 7 years ago

Alright, yeah I think that sounds better. Thanks for your input! I will fix that later

ghost commented 7 years ago

Hi @allenhwkim , could you please review when you have a chance? :) Sorry I took too long, I was kind of busy

ghost commented 7 years ago

@allenhwkim any news on this? Would you like to change something else?

allenhwkim commented 7 years ago

Thank you, it is published as 0.13.6