search

ng2-ui / auto-complete

Angular Auto Complete component and directive
https://ng2-ui.github.io/dist/#/auto-complete
MIT License
279 stars 123 forks source link

directive rtl support #263

Closed anysite closed 6 years ago

anysite commented 7 years ago

Current behavior

In directive, on rtl enviroment, the box is out of place. The reason - style given to list is left:0; Plunker: http://plnkr.co/edit/ajL968p8NQXJNEtbdGy6?p=preview

Expected/desired behavior

Make option to rtl box - would make right:0 instead of left:0;

Other information

If it's needed, I can fix it myself and make pull request, just want to know if there is a way to do it in current code

allenhwkim commented 7 years ago

Thanks for reporting this. The stylesheet can be overwritten by user for this. However, if there is a generic solution, a PR would be appreciated.

anysite commented 7 years ago

But this is not stylesheet. That's hard coded in js, and css hardly can override inline css

file: src/auto-complete.directive.ts function: styleAutoCompleteDropdown

this.acDropdownEl.style.left = "0";

allenhwkim commented 7 years ago

@anysite sorry for misunderstanding, please make a PR for this

anysite commented 7 years ago

PR: #264 Hope I did it well, my first PR in github