search

ng2-ui / auto-complete

Angular Auto Complete component and directive
http://ng2-ui.github.io/auto-complete/
MIT License
279 stars 124 forks source link

Upgrade Angular 2 to Angular 4 including material upgrade as well + new features #265

Closed almothafar closed 7 years ago

almothafar commented 7 years ago

I think we close to Angular 5 and we still on Angular 2 here :)

allenhwkim commented 7 years ago

Please make a PR without a build

almothafar commented 7 years ago

@allenhwkim reversed the building commit, I pushed it for my fork but it seems the PR get it directly, forgot to create a new branch for PR :) .

allenhwkim commented 7 years ago

Still having conflict. Could you make a PR after resolving the conflict?

almothafar commented 7 years ago

@allenhwkim merged with previous pull request

allenhwkim commented 7 years ago

The test is failing after the merge. Can you fix the test? e.g., npm test

#Test with array of id/value
  > verify element #model2 value is "One"
  > click link "Change It"
  > verify element #model2 value is "it"
  > click #model2
  > clear #model2
  > press "o" into "#model2"
  > verify element "ul li:nth-child(1)" text is "Select One"
  > verify element "ul li:nth-child(2)" text is "(1) One"
  > see "Select One"
  > click
  > verify element #model2 value is ""

When we select the "Empty field", the value of ngModel must be empty. but the value of ngModel still remains as the user-entered value, which is "o"

image

This may cause other user to get very confused. @almothafar Please create a bug issue if necessary for this since it is already merged.

BTW, I will not release a new version until this issue is fixed although the source code is merged.

almothafar commented 7 years ago

bull request #271 is ready to fix this