search

ng2-ui / auto-complete

Angular Auto Complete component and directive
https://ng2-ui.github.io/dist/#/auto-complete
MIT License
279 stars 123 forks source link

Angular 5 #316

Closed tunnel closed 6 years ago

allenhwkim commented 6 years ago

@ndcunningham Please review, test, and merge this PR. It has major changes, but I can't keep up with Angular breaking changes(3/4/5) since I don't work with it.

ndcunningham commented 6 years ago

i don't understand why this commit is made from this branch? complete rewrite from webpack.config.js with no changes to package.json for angular upgrade to v5 @tunnel @allenhwkim . What's going on here?

allenhwkim commented 6 years ago

@ndcunningham I donno what's happening here. 0.5.5? Regarding maintainer, If you want to maintain this repo, please send me your npm id, I will give you full permission of npm publish.

@tunnel, please make another PR from the recent branch without dist folder, 0.16.1.

@ndcunningham please add dist to .gitignore, so that users don't make PR with dist. dist is only good for npm. You can have sample here, https://github.com/ng2-ui/map/blob/master/.npmignore and https://github.com/ng2-ui/map/blob/master/.gitignore. Please close this PR if @tunnel agrees to it.

ndcunningham commented 6 years ago

@allenhwkim you don't want to maintain this anymore? It was regarding this PR with what i highlighted being: Rewrite of webpack and no version update for angular 5 when the title of the PR is angular 5. Amongst other things...

allenhwkim commented 6 years ago

@ndcunningham no, I may comeback later, but for now, I don't want to maintain this. Since I am not using this package at my work place(not using Angular2-5), I found myself not active with this package, and decided to share/pass the ownership to someone who is active.

almothafar commented 6 years ago

This is outdated and does not look like it will work, closing it.