search

ng2-ui / auto-complete

Angular Auto Complete component and directive
https://ng2-ui.github.io/dist/#/auto-complete
MIT License
279 stars 122 forks source link

support angular 9 #384

Closed webcat12345 closed 4 years ago

webcat12345 commented 4 years ago

Current @ngui projects are not working on new Angular 9.

Completed:

TODO:

~Important: The status of this PR is WIP (work in progress), just confirming that you are willing to accept this kind of update. Please let me know if you guys are going to approve this PR, of course after complete~

webcat12345 commented 4 years ago

@almothafar This pull request is ready to be merged. Please review it. Thank you.

webcat12345 commented 4 years ago

Thanks for reviewing @almothafar . I have updated npm script - build-lib:prod, please check the last commit. FYI, auto-complete/package.json is just the base project which is mainly running the demo. Library package.json should be there in the auto-complete/projects/auto-complete/package.json. I have updated it according to your comments, you can verify if those are correctly formed.

webcat12345 commented 4 years ago

@almothafar Could you please review this PR soon? Actually our product is depending on this library and we can't update to the Angular 9 due to this problem. Thank you.

almothafar commented 4 years ago

@webcat12345 sorry for the delay, as I'm moving to a new house and my internet is not set up yet (And I'm not allowed in my work to do contributions out of projects scope), I merged it, but still, I need to test and distribute it.

almothafar commented 4 years ago

Just to keep you updated, still without the internet until now, hopefully, this week ISP set up it.

tpapagiannis commented 4 years ago

Still without ISP ?

almothafar commented 4 years ago

@tpapagiannis it is merged and released already under version 3.0.0, if you have a problem, please say it straight.