search

ng2-ui / datetime-picker

Angular2 DateTime Picker
https://ng2-ui.github.io/#/datetime-picker
MIT License
121 stars 62 forks source link

ngModel not updated when selecting only time #17

Closed 0cv closed 7 years ago

0cv commented 8 years ago

It looks like ngModel is not updated on the latest version (currently 0.6.0) when a time on the slider is selected and the popup is closed. However, when changing additionally the date, it works as expected.

allenhwkim commented 8 years ago

Thanks for reporting this.

0cv commented 8 years ago

Apart from this, would it be maybe a good occasion to support also formControl, independently of ngModel?

0cv commented 7 years ago

looks like the time is updated again (just tested in 0.8). Not sure whether it's because of the RC6 or you did anything. Closing anyway this issue.

allenhwkim commented 7 years ago

Thanks for your patience, I made some changes for this.

About ngModel, I can think of some output event, so that when value is change, we can have some callback. e.g. (valueChanged)="myCallback($event)

I do not heavily use formControl, so I am not confident on using this, but any PR would be welcome.