I forgot to add show-today-shortcut to the directive also (was only in the component)

ng2-ui / datetime-picker

Angular2 DateTime Picker

https://ng2-ui.github.io/#/datetime-picker

MIT License

121 stars 62 forks source link

Closed mmanneva closed 7 years ago

mmanneva commented 7 years ago

I've added the today-shortcut to the directive also now.

Markus

mmanneva commented 7 years ago

I fixed a layout bug that happens if using a global css directive to set all box-sizing to border-box.
There is a check for a global moment object in several places of datetime.ts, but one of them fails if the moment object is not there. I fixed this null-check but noted that the datetime picker does not work at all if there is no moment-object in the global scope. However, I didn't investigate it further.

mmanneva commented 7 years ago

The safest way to work this for the time being was to declare content-box in all places where it's implicitly assumed.

I removed the -moz- prefix, as we have never used any of the other vendor prefixes.

Seem ok now?

allenhwkim commented 7 years ago

I will merge it for now, but it might be changed to 'border-box' later when if necessary.

mmanneva commented 7 years ago

Sounds great!

mmanneva commented 7 years ago

Hi again, any projection regarding when this'll be in a release? I'm deciding whether or not I should use a direct github reference in our project.