ng2-ui / scrollable

Angular2 Automatic Scroll Detection With Animation
17 stars 10 forks source link

Fixed to work with FireFox #13

Closed rajezvelse closed 7 years ago

rajezvelse commented 7 years ago
 I just slightly changed the scroll container selection, to make working on both firefox & chrome.
allenhwkim commented 7 years ago

Thanks for this PR, but please make a PR without build. This makes the change commit(PR) simple and clear, and build commit will be made separately when merged and published.

rajezvelse commented 7 years ago

Okay sure.

On 21 August 2017 at 19:47, Allen Kim notifications@github.com wrote:

Thanks for this PR, but please make a PR without build.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ng2-ui/scrollable/pull/13#issuecomment-323754032, or mute the thread https://github.com/notifications/unsubscribe-auth/AT1egPzBkM3t6nLY3CiBZS_ttnL-XZK9ks5saZF-gaJpZM4O9X1N .

rajezvelse commented 7 years ago

@allenhwkim I have reverted the build. I think it should be ok now.

allenhwkim commented 7 years ago

published with release 0.9.2