search

ng2-ui / scrollable

Angular2 Automatic Scroll Detection With Animation
17 stars 10 forks source link

ERROR in Ng2ScrollableModule is not an NgModule #4

Closed yoavdamri closed 7 years ago

yoavdamri commented 7 years ago

When building my app or serve it i get this error.

after ng serve i can solve the problem by forcing another error. then fix it back. (deleting dependency and return it back) and the ng serve compilation success.

using: angular cli - version 32.3 tsc - version 2.2.1

allenhwkim commented 7 years ago

@yoavdamri thanks for letting me know. I will look into this later. If you do not see any actions in a week, please ping me one more time.

yoavdamri commented 7 years ago

Hi.

I can tell you after some work. It is a build issue. Try to build it with latest version of webpack.

On Thu, Mar 2, 2017, 19:44 Allen Kim notifications@github.com wrote:

@yoavdamri https://github.com/yoavdamri thanks for letting me know. I will look into this later. If you do not see any actions in a week, please ping me one more time.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ng2-ui/ng2-scrollable/issues/4#issuecomment-283725326, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_v06xgc3cOXAi3eJOoJv20CuFCfCeKks5rhv_cgaJpZM4MRCE_ .

--

"חזק ונתחזק בעד עמנו ובעד הרי אלוהינו..."

allenhwkim commented 7 years ago

so updating webpack in package.json will work?

yoavdamri commented 7 years ago

I hope so. To reproduce the bug, build an app using angular cli,and use the package. Than build it with latest version of webpack. And try to build again the ng cli app.

Or update the package and I will try it in my app.

On Thu, Mar 2, 2017, 20:31 Allen Kim notifications@github.com wrote:

so updating webpack in package.json will work?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ng2-ui/ng2-scrollable/issues/4#issuecomment-283738260, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_v09F8R-fmBsL_aq1QrVTSWKTgm-P3ks5rhwsAgaJpZM4MRCE_ .

--

"חזק ונתחזק בעד עמנו ובעד הרי אלוהינו..."

allenhwkim commented 7 years ago

The new version 0.8.0 is released with changes.

sentoro commented 7 years ago

Still having the same issue with Angular cli. Could someone help with it ?

allenhwkim commented 7 years ago

it seems like angular-cli issue. Is anyone having this issue without angular-cli?

yoavdamri commented 7 years ago

To verify this is your issue in your app, Just take the code as is, and put it as a part of your code. If the error dissappear. It is a very good clue this is an angular cli issue.

On Sun, Apr 9, 2017, 04:15 Allen Kim notifications@github.com wrote:

it seems like angular-cli issue. Is anyone having this issue without angular-cli?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ng2-ui/scrollable/issues/4#issuecomment-292756707, or mute the thread https://github.com/notifications/unsubscribe-auth/AF_v04tt4ZGKYW1Lz7ruolyWZpVF0Hy5ks5ruDEvgaJpZM4MRCE_ .

--

"חזק ונתחזק בעד עמנו ובעד הרי אלוהינו..."

sushiie commented 7 years ago

anyone got the issue resolved? I am seeing this error when I am using the module.

rainstormza commented 7 years ago

same error

allenhwkim commented 7 years ago

published a new package. Please verify

wangyang2012 commented 7 years ago

It works fine now.

But it seems you forgot update the version number on the npm package repository because I got always v0.9.0 when I did npm install and I had to specify the git URL to get the latest version.

Please check.