search

ngHelper / ngHelperAirbrake

Integrate AirBrake into an angular.js application
4 stars 5 forks source link

jQuery 1.x #1

Open yuyaohshimo opened 9 years ago

yuyaohshimo commented 9 years ago

Can we use ngHelperAirbrake with jQuery 1.x? If so, please update dependencies in bower.json.

dei79 commented 9 years ago

Currently I'm not sure because this was a dependency we got from the AirBrake SDK. Do you know if it's officially supported?

yuyaohshimo commented 9 years ago

Please see Readme.md in https://github.com/airbrake/airbrake-js. The document says we can use jQuery 1.10.2.

lunks commented 9 years ago

This dependency should probably be removed. There seems to be no direct dependency for airbrake-js: https://github.com/airbrake/airbrake-js/blob/master/package.json

dei79 commented 9 years ago

Looks you are right, can't find any dependency to the airbrake component. Looks like the airbrake team got rid of the shim thing and so now jquery include is required at all:

https://github.com/airbrake/airbrake-js/blob/master/src/instrumentation/jquery.coffee

https://github.com/airbrake/airbrake-js/issues/81

I will check this with the next update