search

ngMorocco / ngx-darija

Official Angular in Darija landing page containing all video sessions.
https://angularindarija.dev
56 stars 28 forks source link

chore(dependencies): add Commitizen to project #21

Closed airaamane closed 3 years ago

airaamane commented 3 years ago

re #20: Add Commitizen

netlify[bot] commented 3 years ago

Deploy request for ngx-darija rejected.

Rejected with commit 1446b2d190131e8d6dfe84e2df381fd8094a6d7d

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

chihab commented 3 years ago

First time I use commitzen on Windows and the output on PowerShell is quite disturbing:

image

airaamane commented 3 years ago

Interesting, but not unexpected actually. the prepare-commit-message script assumes bash is used, this may be an issue with cz husky hook itself, i will look around if anyone has a solution. in the meantime, could you try running cz (just cz in cli), see if you still get this duplication please even when bypassing husky hook

chihab commented 3 years ago

I don't have the issue when running only cz, so as you said the issue is from the husky hook. You probably saw the discussion here https://github.com/typicode/husky/issues/720