search

ngMorocco / ngx-darija

Official Angular in Darija landing page containing all video sessions.
https://angularindarija.dev
56 stars 28 forks source link

feat: display page for video session detail #26

Closed ikourfaln closed 3 years ago

ikourfaln commented 3 years ago

ngxscreenrecord

netlify[bot] commented 3 years ago

Deploy request for ngx-darija rejected.

Rejected with commit 54b4516ef0ce4f4df91f9d9fd142fa90cfeb9244

https://docs.netlify.com/configure-builds/environment-variables/#sensitive-variable-policy

Mubramaj commented 3 years ago

Hi @ikourfaln nice PR! I think the tests are broken :s if you run yarn test you will see. I don't know if we want to keep going with jasmin and karma but we can use github action to run tests for each PR. What do you think @chihab ?

chihab commented 3 years ago

Hi @ikourfaln nice PR! I think the tests are broken :s if you run yarn test you will see. I don't know if we want to keep going with jasmin and karma but we can use github action to run tests for each PR. What do you think @chihab ?

You're right @Mubramaj we should definitely run test on every single PR and we'll progressively move to Jest. We'd better not write too much tests now until we're decided about our testing strategy, which should have a dedicated episode ;)

Mubramaj commented 3 years ago

Ok it make sense, I like Jest , @ikourfaln since we are not focusing on testing right now I think if you just remove the .spec.ts from this PR then the yarn test will work again with the little tests we already have

ikourfaln commented 3 years ago

Ok it make sense, I like Jest , @ikourfaln since we are not focusing on testing right now I think if you just remove the .spec.ts from this PR then the yarn test will work again with the little tests we already have

@Mubramaj Done