search

ngMorocco / ngx-darija

Official Angular in Darija landing page containing all video sessions.
https://angularindarija.dev
56 stars 28 forks source link

docs: added documentation on how to test pre rendered app locally #30

Closed Mubramaj closed 3 years ago

Mubramaj commented 3 years ago

I saw a lot of differences (especially on the first load) between when we use app in local compared to when it's prerendered and deployed on the server so I added some instructions on how to test the app prerendered like it is on the prod server

chihab commented 3 years ago

I saw a lot of differences (especially on the first load) between when we use app in local compared to when it's prerendered and deployed on the server so I added some instructions on how to test the app prerendered like it is on the prod server

Could you please describe what differences you see?

Mubramaj commented 3 years ago

I saw a lot of differences (especially on the first load) between when we use app in local compared to when it's prerendered and deployed on the server so I added some instructions on how to test the app prerendered like it is on the prod server

Could you please describe what differences you see?

If you go to https://ngx-darija.netlify.app/sessions/rT0FUs7uUks and you refresh several time you will see the home page displaying first before the session details. This is because we only prerender the home page. This behaviour is not noticable when we use netlify dev because there is no pre rendering.

I am now working on a PR to prerender dynamic routes for session to remove this issue. Will push the PR in max 20 min

Mubramaj commented 3 years ago

@chihab Pull request ready https://github.com/ngMorocco/ngx-darija/pull/32/files

Mubramaj commented 3 years ago

@chihab this should be good to go unless there is still some language tweak or spelling mistakes :P