search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 67 forks source link

Component to create: MessageBar #339

Closed ghost closed 8 years ago

ghost commented 8 years ago

MessageBanner is in the latest release (2.6.0) of Office UI Fabric. Not on dev.office.com yet.

See: https://github.com/OfficeDev/Office-UI-Fabric/pull/515 and https://github.com/OfficeDev/Office-UI-Fabric/releases/tag/2.6.0

andikrueger commented 8 years ago

I would suggest the following specs:

<uif-message-bar type="Error|Remove|SevereWarning|Success|Warning|NONE">
  <uif-content>
    lorem ipsum dolor sit amet, a elit sem interdum consectetur adipiscing elit
  </uif-content>
  <uif-link ng-href="http://ngofficeuifabric.com">Link text</uif-link>
</uif-message-bar>

Plnkr with a messagebar demo: DEMO

jjczopek commented 8 years ago

I would change typeto uif-type. It should be an enum with following values: error|remove|severewarning|success|warning. By default it's not specified.

I'm ok with the rest.

I could take that one as I actually was missing this feature on my project.

andikrueger commented 8 years ago

Thanks for your input. I absolutely agree on the type as uif-type thing. I'm already half way through with the directive. I already started working on it... :)

andikrueger commented 8 years ago

@jjczopek I published my dev-branch. Would you give it a try?

andikrueger commented 8 years ago

I could not use uif-icon in the directive, because there are two classes needed to render the icons properly. Mabe this could result in a feature request for uif-icon.