$dirty not being set on uif-commandbar

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular

http://ngOfficeUiFabric.com

MIT License

321 stars 67 forks source link

$dirty not being set on uif-commandbar #376

Closed andrewconnell closed 7 years ago

andrewconnell commented 8 years ago

Refer to #361 for more information.

Steps to Reproduce Behavior

http://plnkr.co/edit/qzfvrxDRYh0CmVEzPQtH?p=preview

jjczopek commented 8 years ago

Should command bar actually be considered as a component used in forms? For me at least it does not make much of a sense.

Also on the demos we have right now on the website, it doesn't look like the component even intends to be leverage ng-model. It's leveraging ng-click and custom binding of the search term.

IMHO this $dirty not being set issue is not applicable to uif-commandbar.

andrewconnell commented 7 years ago

Agreed with @jjczopek ... closing this as not relevant.