search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 67 forks source link

fix(dialog) Add type="button" to the <button> element #396

Closed ghost closed 8 years ago

ghost commented 8 years ago

Closes #392

andrewconnell commented 8 years ago

Maybe its been too long since I looked at this, but I can't see how this is working in the demo. The demo doesn't show the close button in the top-right corner. When I manually add it, clicking on the X does nothing... wasn't the point of adding this attribute to make sure it actually closed the dialog?

andrewconnell commented 8 years ago

Bump... @tobiaswest83 mind taking a look at the issue I mentioned above so we can get this merged?

andrewconnell commented 8 years ago

Closing due to lack of response... please resubmit once issue above addressed or clarified - https://github.com/ngOfficeUIFabric/ng-officeuifabric/pull/396#issuecomment-234924470