The documentaion for searchbox contained an error

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular

http://ngOfficeUiFabric.com

MIT License

321 stars 67 forks source link

The documentaion for searchbox contained an error #415

Closed calin-stan closed 7 years ago

calin-stan commented 7 years ago

Closes #413 In the documentation for searchbox, it said to use the uif-value attribute to specify the value of the search field, when in fact it was just value.

coveralls commented 7 years ago

Coverage remained the same at 97.46% when pulling 84edcc3fdd2842b50497261e40860a188553e60b on calin1611:issue-DocumentationIncorrectForSearchbox into 44bab54781cb477454503155b23d62cd46d98ad0 on ngOfficeUIFabric:dev.

andrewconnell commented 7 years ago

While merged into dev, there are issues without build... tests are failing, but they aren't being caught by the CI process as errors. Fixing this before we push to master.

calin-stan commented 7 years ago

Is there something that I can do about this?

andrewconnell commented 7 years ago

No... nothing wrong with your PR... I'm just leaving it as open until it's in master as right now it's only in dev. Working to this other issue resolved (see: #417)