search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 67 forks source link

fix(datepicker): $dirty and $touched handling for uif-datepicker #426

Closed jjczopek closed 7 years ago

jjczopek commented 7 years ago

Added support for $touched property on ngModel. Fixed issue with $dirty being set on ngModel when initial value was bound to the model.

Closes #377, #410.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.05%) to 97.586% when pulling 30d8382367ea657c040254c134e3ed2b552ffa2b on jjczopek:datepicker-fixes into 79e6e03d74e4cc4fcc06e1b5f00194bd10f1ea82 on ngOfficeUIFabric:dev.

andrewconnell commented 7 years ago

Green build, but when checking the demos, there's an error when the page loads, then there's a pair of errors when I try the last demo:

image

jjczopek commented 7 years ago

Will have a look later. I thought all was fine ;)

andrewconnell commented 7 years ago

bump :)

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.06%) to 97.593% when pulling fe7efd306a9cd35a55a682a715755309b51ea711 on jjczopek:datepicker-fixes into 96ecdc9046edc354194d047d0c2d25a5402a1c4e on ngOfficeUIFabric:dev.

jjczopek commented 7 years ago

I've added couple of null-checks and it looks better now ;) Errors where comming from demos that don't have ngModel associated with the control.