search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
320 stars 67 forks source link

Added option to allow items in table to be selected #464

Closed emilverwoerd closed 7 years ago

emilverwoerd commented 7 years ago

Changed uif-table and added property uif-selected-items which allows to get information about the selected records in the table

coveralls commented 7 years ago

Coverage Status

Coverage decreased (-0.1%) to 97.524% when pulling 2c32d06c63b9ce7efd810c7227f0bfae8bbe3431 on emilverwoerd:bug/selecteditemstable into 7f88ffea0b26faa971fd5d185fef5948daec270b on ngOfficeUIFabric:dev.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 97.679% when pulling 2b5b3bf33504fbe62d869a4831304b4ff36e5e16 on emilverwoerd:bug/selecteditemstable into 7f88ffea0b26faa971fd5d185fef5948daec270b on ngOfficeUIFabric:dev.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.04%) to 97.679% when pulling 8d469df0abb6259132f04c85fc73c8d80f3eb2ef on emilverwoerd:bug/selecteditemstable into 7f88ffea0b26faa971fd5d185fef5948daec270b on ngOfficeUIFabric:dev.

emilverwoerd commented 7 years ago

Going to implement the requested changes. Also the examples are faulty with the controller on a <p> tag will fix that also.

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.1%) to 97.753% when pulling 28817b624d9a05761649df4a3dba29986f02c39b on emilverwoerd:bug/selecteditemstable into 7f88ffea0b26faa971fd5d185fef5948daec270b on ngOfficeUIFabric:dev.

emilverwoerd commented 7 years ago

Hi Andrew thanks for adding but is there a reason why the .spec file isn't updated

andrewconnell commented 7 years ago

It isn't? I merged your changes... what's missing? If there's an issue, can you create an issue, self-assign and a new PR that closes it?

I had to squash your commits into one as we only merge a PR as a single commit... I might have made a mistake in that as there were a lot of conflicts between your multiple commits.

emilverwoerd commented 7 years ago

well the file 'tableDirective.spec.ts' wasn't updated for the rest it looks quite good so I could add a PR and fix it.

andrewconnell commented 7 years ago

My bad... would you mind creating an issue documenting the problem? While I let this one pass, we really want every PR to be tied to an issue.