search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
320 stars 67 forks source link

BUG and A FIX #465

Closed San-Jeevan closed 7 years ago

San-Jeevan commented 7 years ago

Dropdown doesnt set value on the view to be the selected value.

faulty line: instanceElement.find('span').html()

instanceElement .on('click', function (ev) { scope.$apply(function () { dropdownController.setViewValue(instanceElement.html(), attrs.value, ev); }); });

andrewconnell commented 7 years ago

Can you be more specific where this is? Is this in the source / demo? Specific line number & file would be helpful ;) or even a PR would be really helpful... ;)

Rus7am commented 7 years ago

I guess this is the same problem I've just experienced with AngularJS 1.6.0/1: no selected value is shown. Works fine with 1.5.9

If I update angular dependency in the source code to 1.6.1 (in package.json) I get 19 failed tests.

andrewconnell commented 7 years ago

@Rus7am - We're aware of that issue with upgrading to 1.6.1... see #431. There were some jQuery updates in that version of Angular that impact our tests, but not our underlying codebase. However we won't rev until all tests pass so we need to fix that issue...

andrewconnell commented 7 years ago

Closing this issue as the OP didn't follow up with more detail & can't find the code they reference or the exact problem. Please submit a repo per the issue template instructions if you want to resubmit.