search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 67 forks source link

Do not display button to remove items when picker is disabled #466

Closed ericivarsson closed 7 years ago

ericivarsson commented 7 years ago

Added condition ng-if="!ngDisabled" to the button element.

Fixes #461

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 97.639% when pulling 7e320a0a88fc7cc40032900a66f87c6b32301ed3 on ericivarsson:master into 7f88ffea0b26faa971fd5d185fef5948daec270b on ngOfficeUIFabric:dev.

andrewconnell commented 7 years ago

@ericivarsson why did you close this?

ericivarsson commented 7 years ago

@andrewconnell sorry, I might have been a little quick on creating this PR. Could be mistaking but I don´t think OfficeUIFabric peoplePicker supports disabled state and I´m not sure how to proceed. This PR fixes the issue by removing the delete-user-buttons but it does not do anything about the looks of selected items in an disabled peoplePicker.

I guess in order to make the disabled peoplePicker with selected values look contistent with the other input components we would need CSS for .is-disabled similar to how the textField and SearchBox works. ms-SearchBox.is-disabled. What do you think? Let me know if you want me to reopen.

andrewconnell commented 7 years ago

Merged into v0.14.0