search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 68 forks source link

Angular 1.6 #431 #483

Closed jjczopek closed 7 years ago

jjczopek commented 7 years ago

Updated Angular library dependency to 1.6.2. Fixed all failing tests by either updating the tests and/or updating the directives.

Most (all?) failures were coming from the fact that angular is now not adding dummy span element with ng-scope class. Tests have been expecting this SPAN to be present, thus selectors were not returning proper elements and/or assertions on children count were offset by 1 mostly.

In uif-button directive I had to change the way labels are handled, because previously label was considered to be a span, but that's not longer the case.

Fix for each directive has separate commit for easier review (I hope @andrewconnell will forgive me 😄 )

coveralls commented 7 years ago

Coverage Status

Coverage increased (+0.002%) to 97.764% when pulling 77f3047d3d4a2453cc7f09170840e327e51b34a0 on jjczopek:angular-1.6-#431 into e2c6b43099037d7c8d8c13a9011bbe91f29df2c5 on ngOfficeUIFabric:dev.

TheSamsterZA commented 7 years ago

I just tried this in a sample project targeting Angular 1.6 and it fixes a bunch of issues. 🎉

@andrewconnell could this PR please be fast-tracked to be merged and then released?

andrewconnell commented 7 years ago

Merged into master.