search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 68 forks source link

uif-choicefield: throwing lots errors on dirty setting #500

Closed andrewconnell closed 7 years ago

andrewconnell commented 7 years ago

Expected Behavior

No errors thrown

Actual Behavior

Lots of errors thrown

Steps to Reproduce Behavior

Go to live demo http://ngofficeuifabric.com/demos/uifChoicefield, open dev tools & try last demo.

architshukla commented 7 years ago

This seems to be happening due to a missing check for the absence of ng-model here. Making the change locally fixes the issue for the third and the last examples.

I have two questions though:

  1. In the last example, it's possible to select multiple radio buttons. Is this expected? image

  2. The third (checkbox) example is currently throwing errors as well due to the same reason. Even though the errors go away after the fix, the ng-model on the checkbox doesn't seem to be working: image The value of selectedCheckbox isn't being set in either state. Am I missing something?

andrewconnell commented 7 years ago

Thanks for the suggested fix... want to submit a PR and help out?

For the other thing you mention, seems a dupe of #482