search

ngOfficeUIFabric / ng-officeuifabric

Office UI Fabric (https://github.com/OfficeDev/office-ui-fabric) implementation for Angular
http://ngOfficeUiFabric.com
MIT License
321 stars 68 forks source link

Update dependency on Angularjs to 1.6.10 #513

Closed Sjark closed 6 years ago

Sjark commented 6 years ago

Update angularjs dependency to 1.6.10, the newest version in the 1.6.x branch.

Sjark commented 6 years ago

Not sure why the circleci build fails. It works locally when using yarn install and yarn run build:ts, might be because the CI build uses npm?

andrewconnell commented 6 years ago

We're not going to switch the package manager out of the blue as NPM has worked just fine in the past.

That's coming from someone who prefers Yarn over NPM.

andrewconnell commented 6 years ago

The build details indicate there's an error in dependencies: https://circleci.com/gh/ngOfficeUIFabric/ng-officeuifabric/313

There haven't been any updates to this project in a VERY long time... the last real update was almost 18 months ago: https://github.com/ngOfficeUIFabric/ng-officeuifabric/graphs/code-frequency

The project has been in a "archive" or "maintenance" state since then as there's no new dev being added.

Sjark commented 6 years ago

I have no problem with that, only saw that there was no package-lock.json, only yarn.lock, so I bet that is the reason the build is failing. I'll have a look at getting the build working using npm.

andrewconnell commented 6 years ago

That's only because at the time, there was no locking capability in NPM. The fact it's there doesn't do anything unless Yarn is being used.

coveralls commented 6 years ago

Coverage Status

Coverage remained the same at 98.472% when pulling 1153f44d38971e891149c604261513d574ec16f5 on Sjark:dev into 08a048f43659f6e2777f8da1302ead9d66931135 on ngOfficeUIFabric:dev.

Sjark commented 6 years ago

Any thoughts on my latest commit? It builds fine now.

andrewconnell commented 6 years ago

Yeah sorry... I process PR's for a few repos at the same time and this just happened to get in the day after I do that... got a lot on my plate this week and also planning to do a few other changes to the docs on this repo at the same time when I do a push. Will get to it within the week. Sorry for the delay.

andrewconnell commented 6 years ago

Manually merged and rolling out as 0.16.10