ng-forward with jquery causes inconsistent event info

ngUpgraders / ng-forward

The default solution for those that want to write Angular 2.x style code in Angular 1.x

411 stars 36 forks source link

ng-forward with jquery causes inconsistent event info #107

Closed david-gang closed 8 years ago

david-gang commented 8 years ago

When i throw an event with next:

If i don't use jquery i can use $event.detail to get the data.
If i use jquery i have to write $event.originalEvent.detail

I am not sure that it should be handled by ng-forward, but this means that if i add jquery for any reason i will have to go over my code and change many lines.

timkindberg commented 8 years ago

Because there is a way to have it work in both cases I'm not sure we'd take this on as a priority. So I'll close this. If it becomes an annoyance for enough people we can reopen it.

MikeRyanDev commented 8 years ago

On the bright side, our CustomEvent dispatching seems flakey, and it may be worth switching to virtual events using jQLite/jQuery.

timkindberg commented 8 years ago

@MikeRyan52 you can reopen if you want.