search

ngUpgraders / ng-forward

The default solution for those that want to write Angular 2.x style code in Angular 1.x
411 stars 36 forks source link

Attempt for fixing unit tests #173

Closed david-gang closed 8 years ago

david-gang commented 8 years ago

Hi all, I know this project is abandoned but i have an important project written with this infra structure and have to maintain this module. What i want to achieve is that i can upgrade the rxjs version to beta 10. i want to use angular with rxjs and fear that multiple versions of rxjs will screw things up.

Thanks, David

david-gang commented 8 years ago

I don't know why travis is not run

timkindberg commented 8 years ago

What is this PR doing? just modifying a path to have /lib?

Remember you can always just fork the repo :)

david-gang commented 8 years ago

Yes. Therefore everything downstream works. As you can see the build is failing before this modification and now it does not. I already forked the repo and downgraded it to 0.12 alpha. I would prefer not to fork the repo and make my fixes alone as then i would have to face all the issues alone without any help.

timkindberg commented 8 years ago

You feel pretty good about it? I can merge it but don't have time to really check. So if you can say you feel confident it needs to be added then I will merge it.

david-gang commented 8 years ago

I checked the diff if the resulting files and they were mostly the same. There were small changes in the dist file, but i plugged the resulting file in the node modules folder and everything worked.

timkindberg commented 8 years ago

Alright... I merged it... let's see if it works. Please submit a follow up PR if we need to revert or anything.

david-gang commented 8 years ago

Great :+1: