search

ngUpgraders / ng-forward

The default solution for those that want to write Angular 2.x style code in Angular 1.x
411 stars 36 forks source link

fix(build): Remove sinon-chai from karma frameworks #95

Closed brandonroberts closed 8 years ago

brandonroberts commented 8 years ago

Fixes errors with build

timkindberg commented 8 years ago

Hmm build is still broken. I've been trying to fix it for s couple days now. Is this PR trying to fix it?

If you look at the PR called issue-82 you can see I've tried upgrading babel. But both of our PRs are still failing on CI. Any ideas?

brandonroberts commented 8 years ago

Yep. I had gotten the build to work locally after upgrading babel-core, but it was using npm 2.14.7 instead of npm 3. I'll try to replicate it locally with npm 3 and see where it goes

brandonroberts commented 8 years ago

Hmm. This works locally, but fails in Travis

brandonroberts commented 8 years ago

The current issue is that Travis uses Chromium version 37, which doesn't support Set. Support for Set wasn't added until Chrome 38.

timkindberg commented 8 years ago

If you can keep looking at this it would be great. I will not have time for several days still :(

brandonroberts commented 8 years ago

@timkindberg will do

brandonroberts commented 8 years ago

@timkindberg @MikeRyan52 build errors are fixed. Something is going on with the test suite that needs more checking on.

timkindberg commented 8 years ago

Oh awesome, and we got Symbols back!