search

ngageoint / elasticgeo

ElasticGeo provides a GeoTools data store that allows geospatial features from an Elasticsearch index to be published via OGC services using GeoServer.
GNU General Public License v3.0
169 stars 85 forks source link

Support for Elasticsearch circle geo_shape objects #64

Closed warwickdufour closed 6 years ago

warwickdufour commented 6 years ago

I work in the field of visualising aviation data such as aerodromes, airspaces and airways. Recently I needed to visualise NOTAMs which, at their most basic, consist of a point and circle radius and as far as I know ElasticGeo does not support them.

I have cloned and modified ElasticGeo so that it does support them, albeit quite simplistically. If it is of interest I am happy to contribute my additions to the code base but as it has been a long time since I did so I would like some help with the whole 'pull request' process.

sjudeng commented 6 years ago

Sounds great. Thanks for thinking of contributing the feature. Here are some links on the PR process in general.

  1. Fork this project
  2. Add remote for your fork:
    git remote add warwickdufour https://github.com/warwickdufour/elasticgeo.git
  3. If you haven't already create a branch for your feature:
    git checkout -b circle
  4. Push your feature branch to your remote:
    git push warwickdufour circle
  5. Create pull request through the GitHub UI
  6. (If necessary) push updates to your branch based on pull request review feedback:
    git commit ...
    git push warwickdufour circle
warwickdufour commented 6 years ago

Hi @sjudeng , taken me a while to get round to it I'm afraid but I'm just about to create a pull request. I'm presuming I should 'compare across forks' as per the attached image: screenshot from 2018-04-04 14-04-09

sjudeng commented 6 years ago

Closed in #67