ngageoint / geopackage-android

GeoPackage Android Library
http://ngageoint.github.io/geopackage-android
MIT License
94 stars 32 forks source link

SQLUtils.quoteWrap is broken on Android Q beta #56

Closed solcott closed 5 years ago

solcott commented 5 years ago

Version Information:

Expected Results:

Observed Results:

Steps to Reproduce:

  1. This is happening when trying to import a geoPackage on Android Q beta 3 using geoPackageManager.importGeoPackage(destinationFile, true)
bosborn commented 5 years ago

Can you provide more information? After you imported and opened the GeoPackage, what were you doing with the ContentValues? Inserts? Updates? Followed by a query with unexpected results? or an error? Most importantly, do you have or can your provide an example or a test?

bosborn commented 5 years ago

OK I understand the issue now... https://issuetracker.google.com/issues/132569407

Looking into it. Not quite sure what changed yet in Q with the createFromParcel. This was the work around to call the private map constructor since the ContentValues set methods require exact object types.

bosborn commented 5 years ago

Android Q must have changed something in the Parcel or ContentValues parcel parsing. There is a good amount of language and/or deprecation discouraging non typed values.

Changed SQLUtils to no longer use a Parcel. There is really no great API way to copy a ContentValues with modified keys. The quote wrapping is there for GeoPackages that use non standard (but SQLite allowable) names.

Passes tests for

bosborn commented 5 years ago

Released in 3.3.0