search

ngageoint / geoq

Django web application to collect geospatial features and manage feature collection among groups of users
MIT License
704 stars 133 forks source link

Removing internal IP addresses from initial dataset #291

Closed nstarke closed 8 years ago

nstarke commented 9 years ago

There are internal IP addresses sprinkled throughout the source - I have removed them and replaced the address with a hostname of 'geoserver'. This might break someone's development environment, but its generally bad practice to hardcode internal network information within a git repository. While not exactly sensitive, such information can be used in malicious ways.

Please let me know if I can be of further service or clarify / modify my changes.

stephenrjones commented 9 years ago

Thanks Nicholas -- we received your change and have put it on our list. I'm sure you know, since the IP's in question were from the 192.168.x.x address range, they weren't internal IP's from any particular organization, but instead generic IP addresses as defined in RFC 1918. That being said, you're correct -- it's always a good idea to remove hard-coded IP addresses. We have a monthly get-together to review pull requests and approve them -- once we've gone through that, you'll most likely see your changes pushed up to the server.

nstarke commented 8 years ago

This PR has been open for over a year - as such I want to start a conversation on whether there is any value in this commit. I completely understand if this needs to be rejected, and would be happy to close this pull request if that is the case.

stephenrjones commented 8 years ago

We've gone through and checked that the internal ip's listed are no longer valid. Thanks for the input.