ngageoint / hootenanny-rpms

RPMs needed for a Hootenanny install
GNU General Public License v3.0
5 stars 4 forks source link

Upgrade libphonenumber to 8.12.52 #343

Closed jbronn closed 2 years ago

jbronn commented 2 years ago
jbronn commented 2 years ago

So libphonenumber >= 8.12.40 use the abseil library which complicates the build process here -- it'd have to be added to geoint-deps as a dependency. The simplest path was to just use the last version without abseil: 8.12.39, modified in da0aca3.

hummeltech commented 2 years ago

Awesome work! It looks like we'll just need a new 0.2.72-2 release since there is now a conflict as hootenanny-core requires libprotobuf.so.26 and libphonenumber requires libprotobuf.so.28:

Error: Package: hootenanny-core-0.2.72-1.el7.x86_64 (hoot-release)
           Requires: libprotobuf.so.26()(64bit)
           Available: protobuf-3.15.8-1.el7.x86_64 (geoint-deps-stable)
               libprotobuf.so.26()(64bit)
           Available: protobuf-2.5.0-8.el7.i686 (base)
               Not found
           Installing: protobuf-3.17.3-1.el7.x86_64 (geoint-deps-stable)
              ~libprotobuf.so.28()(64bit)
Error: Package: hootenanny-core-deps-0.2.72-1.el7.noarch (hoot-release)
           Requires: libphonenumber = 8.12.27
           Available: libphonenumber-8.12.27-1.el7.x86_64 (hoot-deps-stable)
               libphonenumber = 8.12.27-1.el7
           Installing: libphonenumber-8.12.39-1.el7.x86_64 (hoot-deps-stable)
               libphonenumber = 8.12.39-1.el7
jbronn commented 2 years ago

@hummeltech why extra caution is warranted at updating protobuf, even a "minor" release, as it'll change the ABI version linked to by dependencies, such as Hootenanny.

hummeltech commented 2 years ago

Yeah, for sure, I can see what you mean. I'm not sure what the best approach to resolving this would be, a new release seems like the way to go. I could revert the changes in the geoint-deps repository, but then libphonenumber would need rebuilding.