Write dataset ingest cucumber test

ngageoint / hootenanny-ui

Hootenanny UI is a submodule of the Hootennany vector conflation project.

ISC License

29 stars 7 forks source link

Write dataset ingest cucumber test #25

Closed bwitham closed 8 years ago

bwitham commented 8 years ago

The existing one was in nodejs with non-public data, so write a cucumber one so we don't go backward in test coverage after ngageoint/hootenanny#385.

create test-files/ui/fgdb-ingest.feature
create test-files/ui/osm-ingest.feature
create test-files/ui/shapefile-ingest.feature

sisskind commented 8 years ago

@bwitham I see the existing node tests as:

ConflateTest.js
IngestTest.js
LoadTest.js
TestUtils.js

Accurate? Could ConflateTest.js already be considered replaced by current nightly cucumber test?

bwitham commented 8 years ago

@sisskind I hadn't ever looked at ConflateTest.js before, but it does look as if it could be replaced by the existing cucumber conflate test at this point.

bwitham commented 8 years ago

Making an attempt at this now will reduce test setup work and overall complexity in hoot in the long run, so I'm going to take a stab at it. Will leave the nightly nodejs tests against the non public data intact, since they provide additional value.

bwitham commented 8 years ago

Just opened other backlog issues for what I think would be useful cucumber tests outside of conflate/ingest/export.

brianhatchl commented 8 years ago

https://github.com/ngageoint/hootenanny/pull/751

FGDB is not implemented at this point because the capybara technique I'm using to upload a file is only working with a single file. I've added a ticket to add support for zipped osm and gdb datasets to hoot, https://github.com/ngageoint/hootenanny-ui/issues/449.