Wood mapped as closed line exports as area

[MikeTho16]

Describe the bug If one maps a Wood (EC030) feature with a closed line, it renders as an area, and exports as an area.

To Reproduce Steps to reproduce the behavior:

1. Start iD editor (or use F5 to refresh, error message is different if this is the second or subsequent Wood feature mapped).
2. Pan to area of the map where there are no other features (so that when you export you get just this one feature).
3. Draw a closed line (perhaps not super common in reality, but not impossible, e.g. a shelter belt around a farmstead)
4. Make sure "Tag Schema:" is set to "MGCP"
5. Search for "Wood"
   
6. Select "Wood (EC030)"
7. Feature renders as an area (note shaded green border):
   
8. Click "Save"
9. Click "Upload"
10. Click "Export"
11. Select "MGCP" for Schema
12. Select "Shapefile" for format
    
13. Click "Export"
14. Save somewhere on local machine
15. Unzip
16. Should be one shapefile, AEC030.*, all MGCP shapefiles whose name starts with "A" are area shapefiles.
17. Open shapefile in a GIS, such as QGIS, and Wood feature is indeed an area.

Expected behavior

• Do not render as an area in iD
• Export as a line.

Screenshots

• Embedded in “To Reproduce” section above.

Desktop (please complete the following information):

• OS: Ubuntu 16.04
• Browser: Firefox
• Version: 85.0.1 (64 bit)

Smartphone (please complete the following information):

• N/A

Additional context

• None

[mattjdnv]

This one is interesting. EC030 (Wood) can be a point, line or area feature in MGCP When translating OSM -> Shape/FGDB/etc the translator tries to figure out what the geometry is (point, line, polygon) and the rules are:

• Single point == Point
• area=yes tag == Polygon
• Is Closed Area && The internal OSM schema says that the feature can be an Area == Polygon
• Otherwise it is a Line.

In the translation script:

• landuse=forest is a Point or Polygon
• natural=tree_row is a Line This gets assigned based on the geometry type of the feature that gets passed to the translator. I.e. if the Core thinks the feature is a polygon, that is what it tells the translator.

@brianhatchl is looking at how the UI passes the geometry type to the translator. so that it gets the translation correct.

[mattjdnv]

Fixed in Hootenanny #4491

[MikeTho16]

I tested on the GC instance.

iD 2.17.3----.17 - resolved Export - resolved