JOSM - Applying a MGCP Preset to Multipolygon removes type=multipolygon tag

[MikeTho16]

Describe the bug If the mapper creates a multipolygon relation in JOSM, and then applies an MGCP preset, JOSM removes the type=multipolygon tag, which makes the relation invalid, and results in an error when attempting to upload.

Applies to It is believed that this applies generally to any MGCP feature code for which an area is a valid representation. This is a list of feature codes which have been tested and have been found to exhibit this error:

• AA010 Extraction Mine
• AA012 Quarry
• AL015 General Building

To Reproduce

1. Open JOSM
2. Download an area
3. Make sure schema is set to "MGCP"
4. Draw a closed way
5. Draw another closed way, this one completely within the first.
6. Select both ways
7. Tools - > Create Multipolygon
8. In the tags panel, JOSM displays:
   
9. Press F3 on keyboard
10. Search for "mine"
11. Click on "MGCP/Culture/Extraction/Extraction Mine"
    
12. Click the "Select" button
13. In the preset dialog box, click "Apply Preset"
14. In the Tag Panel JOSM displays:
    Notice there is no type=multipolygon tag
15. Click upload button:
16. JOSM displays:

Expected behavior

• When applying a preset, do not remove type=* tags

Screenshots

• Embedded in “To Reproduce” section above.

Desktop (please complete the following information):

• OS: Ubuntu 16.04
• JOSM: 9.2.1

Smartphone (please complete the following information):

• N/A

Additional context

• None

[MikeTho16]

I tested this today in JOSM 11.0.0, the behavior is a little different, but I believe it is still an issue.

Here is what the feature looks like with the MGCP schema:

Here is what the feature looks like with the OSM schema (note no tags identifying it as a mine):

Here is what happens when an attempt is made to upload that feature:

[brianhatchl]

Have a fix for this, just need to merge and release.