ngageoint / hootenanny

Hootenanny conflates multiple maps into a single seamless map.
GNU General Public License v3.0
356 stars 74 forks source link

Point General Building(AL015) w/ Feature Function(FFN)=Education(850), & House of Worship Type(HWT)=Religious Community(7) => FFN=Place of Worship(931)) #4737

Open MikeTho16 opened 3 years ago

MikeTho16 commented 3 years ago

Describe the bug In iD under the MGCP schema, if one maps a point General Building(AL015), sets Feature Function(FFN)=Education(850), and House of Worship Type(HWT)=Religious Community(7), iD changes Feature Function(FFN) to Place of Worship(931). According to MGCP_IllogicalAttributeEnumeration_V11_TRD4.xlsx which is part of GAIT, this is a valid combination, and there are many examples of educational institutions that are either run by religious organizations, or that primarily teach religion, such as Madrasas (https://en.wikipedia.org/wiki/Madrasa)

mattjdnv commented 2 years ago

This is an interesting one. AL015 -> Building FFN 850 -> "building = school" HWT 7 -> "building = religious_community"

Looking at the other values for HWT:

    // HWT - House of Worship Type
    // ['HWT','0',undefined,undefined],
    ['HWT','0','house_of_worship','unknown'],
    ['HWT','2','building','cathedral'],
    ['HWT','3','building','chapel'],
    ['HWT','4','building','church'],
    ['HWT','5','building','marabout'],
    ['HWT','6','with_minaret','yes'], // Fixed in pre/post processing
    ['HWT','7','building','religious_community'],
    ['HWT','9','building','mosque'],
    ['HWT','11','building','pagoda'],
    ['HWT','14','building','shrine'],
    ['HWT','15','building','tabernacle'],
    ['HWT','16','building','temple'],
    ['HWT','20','building','synagogue'],
    ['HWT','21','building','stupa'],
    ['HWT','998','building:religious','not_applicable'],
    ['HWT','999','building:religious','other'], // To avoid conflicts

We are going to have the same clash with the other HWT values. E.g. FFN=850 with HWT=20

Which should take precedence? building=synagogue or building=school?

I'm thinking it probably should end up as:

building=synagogue
use = education

OSM Wiki: school OSM Wiki: Synagogue

mattjdnv commented 2 years ago

Adding this into #5180