search

ngageoint / hootenanny

Hootenanny conflates multiple maps into a single seamless map.
GNU General Public License v3.0
358 stars 74 forks source link

NPE in hoot-services derive changeset command building #5686

Closed brianhatchl closed 1 year ago

brianhatchl commented 1 year ago

Something is passing a null value in the command substitution map

java.lang.RuntimeException: Failed to execute: hoot.bin changeset-derive --${DEBUG_LEVEL} -C DeriveChangeset.conf ${HOOT_OPTIONS} -D bounds=${BOUNDS} ${INPUT1} ${INPUT2} ${OSC_FILE} ${ADV_OPTIONS} --stats ${STATS_FILE} --replacement

Caused by: java.lang.NullPointerException
    at hoot.services.command.ExternalCommandRunnerImpl.expandSensitiveProperties(ExternalCommandRunnerImpl.java:330) ~[classes/:?]
    at hoot.services.command.ExternalCommandRunnerImpl.exec(ExternalCommandRunnerImpl.java:172) ~[classes/:?]
    at hoot.services.command.ExternalCommandManagerImpl.exec(ExternalCommandManagerImpl.java:82) ~[classes/:?]
    ... 18 more

and that is being handled poorly here https://github.com/ngageoint/hootenanny/blob/master/hoot-services/src/main/java/hoot/services/command/ExternalCommandRunnerImpl.java#L324-L332

brianhatchl commented 1 year ago

fixed in #5687