search

ngageoint / hootenanny

Hootenanny conflates multiple maps into a single seamless map.
GNU General Public License v3.0
358 stars 74 forks source link

create test folder with parent id of the default root folder id zero #5689

Closed brianhatchl closed 1 year ago

brianhatchl commented 1 year ago

I encountered a broken UI after running core tests that inserted folder with a null parent_id. I may still add some code to the UI to assume this state as the root (id=0) folder as parent.

But investigating which tests were inserting folders with a null parent_id (updated to zero in this PR) led me to this https://github.com/ngageoint/hootenanny/pull/4461.

So wondering why we didn't just do this update back then instead of all the special null handling we introduced.

brianhatchl commented 1 year ago

The 'root' folder gets created in this liquibase changelog https://github.com/ngageoint/hootenanny/blob/master/hoot-services/src/main/resources/db/changelogs/022-FolderMapMappings.xml#L18-L34

so I think it should always be available for these tests.