ngageoint / mage-android

Mobile Awareness GEOINT Environment Android
Apache License 2.0
40 stars 22 forks source link

remove import from view_form_edit_number #39

Closed JoshMcCullough closed 5 years ago

JoshMcCullough commented 5 years ago

Removing this import fixed the error I was getting:

mage-android/mage/build/generated/source/kapt/defaultsDebug/mil/nga/giat/mage/DataBinderMapperImpl.java:25: error: cannot find symbol import mil.nga.giat.mage.databinding.ViewFormEditNumberBindingImpl; ^ symbol: class ViewFormEditNumberBindingImpl location: package mil.nga.giat.mage.databinding e: [kapt] An exception occurred: android.databinding.tool.util.LoggedErrorException: Found data binding errors. Missing import expression although it is registered file:///.../mage-android/mage/src/main/res/layout/view_form_edit_number.xml

newmanw commented 5 years ago

I don't think you can remove the type, did you test number fields after this change? We are not seeing build errors when building with gradle or Android Studio. Can you please provide more information on how you are building.

JoshMcCullough commented 5 years ago

Building as indicated in the README.

I don't know why these Gradle versions were changed locally. I reverted them and build works w/out this change. However, if/when you upgrade the Gradle plugin, I think you'll have to remove this line. It does build fine without it using Gradle plugin v 3.2.1. Feel free to close this.

newmanw commented 5 years ago

We will address this when we upgrade gradle.