Description
The API is currently validating recipe types that contain sub-recipes of itself.
Reproduction Steps
Steps to reproduce the problem:
Create an empty recipe type (Recipe type with no job/recipe/condition nodes)
Edit the empty recipe type.
Open the Recipe Nodes picker and select the empty recipe
Click Validate - Note it succeeds
Click Save - Note it succeeds
Expected behavior
The validation should fail when the recipe type detects itself as a sub-recipe.
Screenshots
Version and Environment Details
Scale API: 7.0.1
Scale UI: 0.9.0
Additional context
I believe the cyclic dependencies are checking both recipe type name and recipe type revision to determine dependency. This check should fail if a sub-recipe of the same recipe type name as the parent is detected. It would also be ideal if the UI would hide the recipe type being edited from the recipe node selection.
Description The API is currently validating recipe types that contain sub-recipes of itself.
Reproduction Steps Steps to reproduce the problem:
Expected behavior The validation should fail when the recipe type detects itself as a sub-recipe.
Screenshots
Version and Environment Details
Additional context I believe the cyclic dependencies are checking both recipe type name and recipe type revision to determine dependency. This check should fail if a sub-recipe of the same recipe type name as the parent is detected. It would also be ideal if the UI would hide the recipe type being edited from the recipe node selection.