search

ngageoint / scale

Processing framework for containerized algorithms
http://ngageoint.github.io/scale/
Apache License 2.0
105 stars 45 forks source link

Job Type Update of manifest impossible #1820

Closed gisjedi closed 4 years ago

gisjedi commented 5 years ago

Description In Scale 5.x series, it is impossible to update the manifest from the API. This means any call to PATCH /api/v6/job-types/{name}/{version} will fail with InvalidJobField exception, if manifest key is included. This makes updates of an existing Seed job type impossible for patch versions.

Reproduction Steps Steps to reproduce the problem:

  1. Create a Seed Job Type via the API: POST /api/v6/job-types/
  2. Attempt to update by patching with a minimal payload: PATCH /api/v6/job-types/my-job/1.0.0/ 
    { "manifest": ... }
  3. Receive a 500 Server Error response.
  4. See the InvalidJobField exception raised in the webserver logs.

Expected behavior I'd expect it to work.

Version and Environment Details

gisjedi commented 5 years ago

https://github.com/ngageoint/scale/blob/7.0.1/scale/job/views.py#L372 - 377 should be applied to https://github.com/ngageoint/scale/blob/5.9.7/scale/job/views.py#L699 - 703

cshamis commented 5 years ago

Won’t fix. Move to 7.

On Mon, Nov 11, 2019 at 10:51 AM Jonathan Meyer notifications@github.com wrote:

Description In Scale 5.x series, it is impossible to update the manifest from the API. This means any call to PATCH /api/v6/job-types/{name}/{version} will fail with InvalidJobField exception, if manifest key is included. This makes updates of an existing Seed job type impossible for patch versions.

Reproduction Steps Steps to reproduce the problem:

  1. Create a Seed Job Type via the API: POST /api/v6/job-types/
  2. Attempt to update by patching with a minimal payload: PATCH /api/v6/job-types/my-job/1.0.0/

{ "manifest": ... }

  1. Receive a 500 Server Error response.
  2. See the InvalidJobField exception raised in the webserver logs.

Expected behavior I'd expect it to work.

Version and Environment Details

  • Scale API: 5.9.7 (note the API in 5.9.7 lies and says its 5.9.6)

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ngageoint/scale/issues/1820?email_source=notifications&email_token=ADZJETBLDVGLHK3HE7VF6ETQTF5ORA5CNFSM4JLXLJ52YY3PNVWWK3TUL52HS4DFUVEXG43VMWVGG33NNVSW45C7NFSM4HYOOO4Q, or unsubscribe https://github.com/notifications/unsubscribe-auth/ADZJETBXZTQWGJWMRMGSUB3QTF5ORANCNFSM4JLXLJ5Q .

emimaesmith commented 4 years ago

Closing as won't fix