search

ngalaiko / tree-sitter-go-template

Golang template grammar for tree-sitter
MIT License
88 stars 29 forks source link

Msvechlas changes #10

Closed qvalentin closed 6 months ago

qvalentin commented 12 months ago

Solved the conflicts, this might be relevant to https://github.com/ngalaiko/tree-sitter-go-template/pull/4, so take a look @baptman21.

According to the tests, this should fix some bugs, I just focused on fixing the conflicts for now, will take a look of the content of the changes later.

baptman21 commented 12 months ago

Hmm personally I'm not too sure about some of the changes. For instance making the entire content of a string enclosed text to be seen as text might prevent coloration in templating such as Hello: "{{ .name }}" In the meantime I'll fix the #4 but I am pretty sure we won't be able to merge both and will need to make a choice

msvechla commented 6 months ago

I'm still using my original branch here as a daily driver and its working great. I haven't tested this upstream version in a while though, so I will give it another try.

I might create a PR to add a few test cases with things that are working on my branch, which we can probably also solve in another way here.