search

ngalaiko / tree-sitter-go-template

Golang template grammar for tree-sitter
MIT License
74 stars 27 forks source link

Current situation of forks #6

Closed qvalentin closed 8 months ago

qvalentin commented 10 months ago

Hello everyone, I would like to open the discussion on the current state of forks of this project. I have seen that several people are actively working on their forks, and want to suggest that we merge the changes to get the best possible grammar. Either we should look to get merge rights for this repo, or pick a fork that we all contribute to.

Also the fixes discussed in https://github.com/ngalaiko/tree-sitter-go-template/issues/3 were never upstreamed.

I'm very interested in creating a bug-free grammar, as I'm using the grammar for helm-ls, currently I'm trying to fix some bugs related to if-else: https://github.com/ngalaiko/tree-sitter-go-template/pull/5.

What is you opinion @msvechla, @baptman21, @Sephix?

Sephix commented 10 months ago

Hello, I've forked the project to adapt it to the html/template package. I have found that it ras not adapted to that, and I've heavily changed it on my side, I've not pushed everything yet, and still have some issues.

Le dim. 29 oct. 2023, 17:29, valentin @.***> a écrit :

Hello everyone, I would like to open the discussion on the current state of forks of this project. I have seen that several people are actively working on their forks, and want to suggest that we merge the changes to get the best possible grammar. Either we should look to get merge rights for this repo, or pick a fork that we all contribute to.

Also the fixes discussed in #3 https://github.com/ngalaiko/tree-sitter-go-template/issues/3 were never upstreamed.

I'm very interested in creating a bug-free grammar, as I'm using the grammar for helm-ls https://github.com/mrjosh/helm-ls/, currently I'm trying to fix some bugs related to if-else: #5 https://github.com/ngalaiko/tree-sitter-go-template/pull/5.

What is you opinion @msvechla https://github.com/msvechla, @baptman21 https://github.com/baptman21, @Sephix https://github.com/Sephix?

— Reply to this email directly, view it on GitHub https://github.com/ngalaiko/tree-sitter-go-template/issues/6, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBV26POLZ3AUPWQDAYNH53YBZY5RAVCNFSM6AAAAAA6U6MALWVHI2DSMVQWIX3LMV43ASLTON2WKOZRHE3DOMBVHA2DIOA . You are receiving this because you were mentioned.Message ID: @.***>

ngalaiko commented 10 months ago

I am open to either archive this project, or give ownership to whomever is open to maintaining it

ngalaiko commented 10 months ago

@Sephix @qvalentin @baptman21 @msvechla - I've added you all as collaborators

baptman21 commented 10 months ago

Thx @ngalaiko, personally I am open to work on this repo. In my case I am using helm quite frequently so I rely on this extension a lot.

qvalentin commented 10 months ago

Thank you @ngalaiko.

I would suggest we agree on always having consent of two people before merging changes.