ngallagher / simpleframework

Simple Framework
178 stars 37 forks source link

WebSockets & Java-WebSocket Library not working #11

Open noblemaster opened 9 years ago

noblemaster commented 9 years ago

Let me just say that SimpleFramework is fantastic :)

In any case, I am having some troubles getting WebSockets to work correctly (using 6.0.1). Although I am able to connect to SimpleFramework's WebSocket communication sometimes fails (succeeds about 30% of the time - JUnit). I am connecting with the Java WebSocket library (https://github.com/TooTallNate/Java-WebSocket). I tried with different protocols to no avail.

It's little bit difficult to find documentation on SimpleFramework's WebSocket, so I am not so sure if I am setting everything up correctly? I was following the spring.xml here (I am doing everything in code): https://github.com/ngallagher/simpleframework/blob/master/simple-demo/simple-demo-chat/etc/spring.xml

Questions:

  1. What protocols are you supporting? All?
  2. Is there any more documentation on how to set up things in code.
  3. Do you have a Java websocket (not JavaScript) library you recommend with SimpleFramework?
  4. Edit: also it appears you are only using 2 threads for the chat demo. Is that correct? For about 1000 connections how many threads do you recommend?
ngallagher commented 9 years ago

Hi,

FYI there is only one protocol, it is the draft standard version 13. In production environments where users have a modern/recent browser this is the only version you will see. Take a look at https://tools.ietf.org/html/rfc6455, I have developed it verbatim from this document alone.

If you think framework does not work, I would need a test case written in Java that can prove your hypothesis. Alternatively, I think perhaps it is best to speak to the developer of the Java WebSocket library, it is much more likely there is a bug here.

Thanks, Niall

pschweitz commented 6 years ago

Hi,

I confirm it is working like a charm ! You can inspire form the webserver I wrote on top of the lib:

https://github.com/pschweitz/CheetahWebserver