MQTT Fixes from Abstract

ngardiner / TWCManager

Control power delivered by a Tesla Wall Charger using two wires screwed into its RS-485 terminals.

The Unlicense

130 stars 55 forks source link

MQTT Fixes from Abstract #571

Open MikeBishop opened 6 months ago

MikeBishop commented 6 months ago

This PR attempts to pull out all the MQTT-related changes from #483, other than #492. This without #492 might be somewhat inconsistent.

Draft because I haven't explicitly tested this yet, just done the work in git to lift it out.

RichieB2B commented 6 months ago

I took a quick look and these changes are not compatible with paho mqtt client v2 and the MQTTv5 protocol. So this PR will probably only work for installs that are still using paho mqtt client v1.

I will fix this when I have more time.

RichieB2B commented 6 months ago

It turned out to be an easy fix, see https://github.com/RichieB2B/TWCManager/commit/69027ca4936320fc8ae10658bc211b9271d95c0a and the paho migration documentation for reference.

MikeBishop commented 6 months ago

Incorporated -- thank you!

ngardiner commented 6 months ago

Looks good, thanks @MikeBishop and @RichieB2B

MikeBishop commented 4 months ago

I tried this merged into my working branch (main + some PRs) and it seems to be working. Appreciate it if someone else can give it a try before we merge.