search

ngauthier / capybara-slow_finder_errors

MIT License
212 stars 19 forks source link

Capybara 3.0 support? #12

Open erikaxel opened 6 years ago

erikaxel commented 6 years ago

Hi,

Capybara 3.0 is released. The gemspec is locked to 2.x. Can you update the gem to work with 3.0?

ngauthier commented 6 years ago

I don't have the time to upgrade it but if you submit an update I'll review and merge.

On Sun, Apr 8, 2018, 6:26 PM Erik Axel Nielsen notifications@github.com wrote:

Hi,

Capybara 3.0 is released. The gemspec is locked to 2.x. Can you update the gem to work with 3.0?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/ngauthier/capybara-slow_finder_errors/issues/12, or mute the thread https://github.com/notifications/unsubscribe-auth/AAA1VlkAH0kUdoNAcpARUNFhvR-XycBTks5tmo57gaJpZM4TLvRi .

aried3r commented 6 years ago

I tried using my own fork but I couldn't even write a test case that fails anymore. I tried refute page.has_content?("abc") but that just waited 10 seconds. With capybara 2.18 as well as 3.0.1.

Sadly I don't have the test case online since I tried in our closed codebase. Maybe @erikaxel, can you try if this gem works for you with 2.18?

kevinhq commented 6 years ago

Guess this is solved by https://github.com/ngauthier/capybara-slow_finder_errors/commit/cf3da37b861a84c26d293fa2ca749e20a56f0d00