search

ngauthier / capybara-slow_finder_errors

MIT License
212 stars 19 forks source link

Capybara dependency should be stricter? #4

Closed mikecmpbll closed 9 years ago

mikecmpbll commented 9 years ago

Doesn't work with Capybara 2.1 or 2.2, because the method signature for synchronize() changed somewhere between 2.2 and 2.4, in 2.1 there is no 2nd argument for options so the gem causes any test that uses synchronize to fail with ArgumentError: wrong number of arguments (2 for 0..1).

ngauthier commented 9 years ago

Yeah, this is the downside with monkeypatches :-(

The gem is so tiny that you could really just lift the code into your project temporarily to diagnose the issue.

mikecmpbll commented 9 years ago

Wasn't a big issue, I just upgraded Capybara :), but thought fixing the dependency might stop this being a problem for anyone else. Great gem by the way, helped me find all those mistakes and ultimately cut about 12s off my test suite.

ngauthier commented 9 years ago

Cool. 12s out of what? That's pretty small. But anything for free is good :smile:

mikecmpbll commented 9 years ago

yeah, we have a quite small test suite with about a few dozen end-to-end capybara workflows and the gem rooted out about 5 slow finders, whole thing takes 30-35 seconds now so it's a nice % improvement.

ngauthier commented 9 years ago

Cool, that is significant!